soroushdes/flatrender
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: make plans list public, fix frontend healthcheck IPv6

Browse Source 
PlansController had a class-level [Authorize] that gated the public
plans list, contradicting the gateway's optionalAuth on /plans. Mark
List/GetById [AllowAnonymous] and resolve tenant optionally so
anonymous callers receive global plans (purchase/current-plan stay
authenticated).

Frontend container stayed "unhealthy" because busybox wget resolves
localhost to IPv6 [::1] while the Next.js standalone server binds
IPv4 only. Use 127.0.0.1 in the healthcheck.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
soroush.asadi
2026-05-30 00:24:53 +03:30
parent 90ac0b81d1
commit 8b86f17645
4 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docker-compose.v2.yml
+1 -1
View File
@@ -297,7 +297,7 @@ services:
gateway: gateway:
condition: service_healthy condition: service_healthy
healthcheck: healthcheck:
test: ["CMD-SHELL", "wget -qO- http://localhost:3000 || exit 1"] test: ["CMD-SHELL", "wget -qO- http://127.0.0.1:3000 || exit 1"]
interval: 30s interval: 30s
timeout: 10s timeout: 10s
retries: 3 retries: 3
services/identity/FlatRender.IdentitySvc/Application/Services/Interfaces/IPlanService.cs
+1 -1
View File
@@ -5,7 +5,7 @@ namespace FlatRender.IdentitySvc.Application.Services.Interfaces;
public interface IPlanService public interface IPlanService
{ {
Task<List<PlanResponse>> ListAsync(Guid tenantId, string? scope); Task<List<PlanResponse>> ListAsync(Guid? tenantId, string? scope);
Task<PlanResponse> GetByIdAsync(Guid planId); Task<PlanResponse> GetByIdAsync(Guid planId);
Task<UserPlanResponse?> GetCurrentPlanAsync(Guid userId); Task<UserPlanResponse?> GetCurrentPlanAsync(Guid userId);
Task<PurchasePlanResponse> PurchasePlanAsync(Guid userId, Guid tenantId, PurchasePlanRequest request); Task<PurchasePlanResponse> PurchasePlanAsync(Guid userId, Guid tenantId, PurchasePlanRequest request);
services/identity/FlatRender.IdentitySvc/Application/Services/PlanService.cs
+1 -1
View File
@@ -10,7 +10,7 @@ namespace FlatRender.IdentitySvc.Application.Services;
public class PlanService(IdentityDbContext db) : IPlanService public class PlanService(IdentityDbContext db) : IPlanService
{ {
public async Task<List<PlanResponse>> ListAsync(Guid tenantId, string? scope) public async Task<List<PlanResponse>> ListAsync(Guid? tenantId, string? scope)
{ {
var query = db.Plans.Where(p => var query = db.Plans.Where(p =>
p.IsActive && p.DeletedAt == null && p.IsActive && p.DeletedAt == null &&
services/identity/FlatRender.IdentitySvc/Controllers/PlansController.cs
+6 -2
View File
@@ -11,15 +11,16 @@ namespace FlatRender.IdentitySvc.Controllers;
[Authorize] [Authorize]
public class PlansController(IPlanService planService) : ControllerBase public class PlansController(IPlanService planService) : ControllerBase
{ {
[AllowAnonymous]
[HttpGet("plans")] [HttpGet("plans")]
[ProducesResponseType(typeof(object), 200)] [ProducesResponseType(typeof(object), 200)]
public async Task<IActionResult> List([FromQuery] string? scope) public async Task<IActionResult> List([FromQuery] string? scope)
{ {
var tenantId = GetTenantId(); var plans = await planService.ListAsync(GetTenantIdOrNull(), scope);
var plans = await planService.ListAsync(tenantId, scope);
return Ok(new { data = plans }); return Ok(new { data = plans });
} }
[AllowAnonymous]
[HttpGet("plans/{planId:guid}")] [HttpGet("plans/{planId:guid}")]
[ProducesResponseType(typeof(PlanResponse), 200)] [ProducesResponseType(typeof(PlanResponse), 200)]
public async Task<IActionResult> GetById(Guid planId) public async Task<IActionResult> GetById(Guid planId)
@@ -43,4 +44,7 @@ public class PlansController(IPlanService planService) : ControllerBase
private Guid GetTenantId() => Guid.Parse(User.FindFirst("tenant_id")?.Value private Guid GetTenantId() => Guid.Parse(User.FindFirst("tenant_id")?.Value
?? throw new UnauthorizedAccessException()); ?? throw new UnauthorizedAccessException());
private Guid? GetTenantIdOrNull() => User.FindFirst("tenant_id")?.Value is { } t && Guid.TryParse(t, out var id)
? id : null;
} }